don't check for < 0 on an unsigned variable (FDO Bug #12924)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-connection.c (_dbus_connection_get_next_client_serial):
	don't check for < 0 on an unsigned variable (FDO Bug #12924)

diff --git a/ChangeLog b/ChangeLog
index 4547176..abc9be2 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,11 @@
 2008-01-15  John (J5) Palmieri  <johnp@redhat.com>
+
+       * patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
+
+       * dbus/dbus-connection.c (_dbus_connection_get_next_client_serial):
+       don't check for < 0 on an unsigned variable (FDO Bug #12924)
+
+2008-01-15  John (J5) Palmieri  <johnp@redhat.com>
        
        * patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
 

diff --git a/dbus/dbus-connection.c b/dbus/dbus-connection.c
index 54f0a92..66f8526 100644 (file)
--- a/dbus/dbus-connection.c
+++ b/dbus/dbus-connection.c
@@ -1378,13 +1378,13 @@ _dbus_connection_unref_unlocked (DBusConnection *connection)
 static dbus_uint32_t
 _dbus_connection_get_next_client_serial (DBusConnection *connection)
 {
-  int serial;
+  dbus_uint32_t serial;
 
   serial = connection->client_serial++;
 
-  if (connection->client_serial < 0)
+  if (connection->client_serial == 0)
     connection->client_serial = 1;
-  
+
   return serial;
 }