hugetlb_cgroup: remove unneeded return value
authorMiaohe Lin <linmiaohe@huawei.com>
Fri, 29 Jul 2022 08:01:04 +0000 (16:01 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 12 Sep 2022 03:25:53 +0000 (20:25 -0700)
The return value of set_hugetlb_cgroup and set_hugetlb_cgroup_rsvd are
always ignored. Remove them to clean up the code.

Link: https://lkml.kernel.org/r/20220729080106.12752-4-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Mina Almasry <almasrymina@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/hugetlb_cgroup.h

index 3793448..630cd25 100644 (file)
@@ -90,32 +90,31 @@ hugetlb_cgroup_from_page_rsvd(struct page *page)
        return __hugetlb_cgroup_from_page(page, true);
 }
 
-static inline int __set_hugetlb_cgroup(struct page *page,
+static inline void __set_hugetlb_cgroup(struct page *page,
                                       struct hugetlb_cgroup *h_cg, bool rsvd)
 {
        VM_BUG_ON_PAGE(!PageHuge(page), page);
 
        if (compound_order(page) < HUGETLB_CGROUP_MIN_ORDER)
-               return -1;
+               return;
        if (rsvd)
                set_page_private(page + SUBPAGE_INDEX_CGROUP_RSVD,
                                 (unsigned long)h_cg);
        else
                set_page_private(page + SUBPAGE_INDEX_CGROUP,
                                 (unsigned long)h_cg);
-       return 0;
 }
 
-static inline int set_hugetlb_cgroup(struct page *page,
+static inline void set_hugetlb_cgroup(struct page *page,
                                     struct hugetlb_cgroup *h_cg)
 {
-       return __set_hugetlb_cgroup(page, h_cg, false);
+       __set_hugetlb_cgroup(page, h_cg, false);
 }
 
-static inline int set_hugetlb_cgroup_rsvd(struct page *page,
+static inline void set_hugetlb_cgroup_rsvd(struct page *page,
                                          struct hugetlb_cgroup *h_cg)
 {
-       return __set_hugetlb_cgroup(page, h_cg, true);
+       __set_hugetlb_cgroup(page, h_cg, true);
 }
 
 static inline bool hugetlb_cgroup_disabled(void)
@@ -199,16 +198,14 @@ hugetlb_cgroup_from_page_rsvd(struct page *page)
        return NULL;
 }
 
-static inline int set_hugetlb_cgroup(struct page *page,
+static inline void set_hugetlb_cgroup(struct page *page,
                                     struct hugetlb_cgroup *h_cg)
 {
-       return 0;
 }
 
-static inline int set_hugetlb_cgroup_rsvd(struct page *page,
+static inline void set_hugetlb_cgroup_rsvd(struct page *page,
                                          struct hugetlb_cgroup *h_cg)
 {
-       return 0;
 }
 
 static inline bool hugetlb_cgroup_disabled(void)