regulator: mc13783-regulator: correct the probing time.
authorAlberto Panizzo <maramaopercheseimorto@gmail.com>
Mon, 14 Dec 2009 17:53:35 +0000 (18:53 +0100)
committerLiam Girdwood <lrg@slimlogic.co.uk>
Thu, 17 Dec 2009 10:27:28 +0000 (10:27 +0000)
When the mc13783-regulator driver is built in kernel, probing it during
the regulator subsystem initialisation result in a fault.

That is because regulator subsystem is planned to be initialised very early
in the boot process, before the mfd subsystem initialisation.

The mc12783-regulator probing process need to access to the mc13783-core
functionality to read/write mc13783 registers and so must be called after
the mc13783-core driver initialisation.

The way to do this is to let the kernel probe the mc13783-regulator driver when
mc13783-core register his regulator subdevice.

Signed-off-by: Alberto Panizzo <maramaopercheseimorto@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
drivers/regulator/mc13783-regulator.c

index 9f99862..39c4953 100644 (file)
@@ -224,12 +224,12 @@ static struct platform_driver mc13783_regulator_driver = {
                .owner  = THIS_MODULE,
        },
        .remove         = __devexit_p(mc13783_regulator_remove),
+       .probe          = mc13783_regulator_probe,
 };
 
 static int __init mc13783_regulator_init(void)
 {
-       return platform_driver_probe(&mc13783_regulator_driver,
-                       mc13783_regulator_probe);
+       return platform_driver_register(&mc13783_regulator_driver);
 }
 subsys_initcall(mc13783_regulator_init);