[coverity] fix coverity issues
authorEunju Yang <ej.yang@samsung.com>
Mon, 18 Mar 2024 08:25:53 +0000 (17:25 +0900)
committerjijoong.moon <jijoong.moon@samsung.com>
Tue, 19 Mar 2024 22:42:01 +0000 (07:42 +0900)
This commit fixes coverity issues of auto_causes_copy
- 1739360
- 1740106

Self-evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Change-Id: I92f7c25de243c931226e65f114613a8d6dc84ec0
Signed-off-by: Eunju Yang <ej.yang@samsung.com>
nntrainer/tensor/task_executor.cpp
nntrainer/utils/node_exporter.cpp

index 2cae75c..c58f9b0 100644 (file)
@@ -29,9 +29,7 @@ namespace nntrainer {
 std::atomic_int32_t TaskExecutor::ids(1);
 
 TaskExecutor::TaskExecutor(const std::string &n) :
-  name(n),
-  run_thread(true),
-  wait_complete(false) {
+  name(n), run_thread(true), wait_complete(false) {
   task_thread = std::thread([&]() {
     ml_logd("Task Thread(%s): start thread", name.c_str());
     while (run_thread) {
@@ -43,8 +41,8 @@ TaskExecutor::TaskExecutor(const std::string &n) :
       auto &task_info = task_queue.front();
       lk.unlock();
 
-      auto id = std::get<int>(task_info);
-      auto callback = std::get<CompleteCallback>(task_info);
+      const auto &id = std::get<int>(task_info);
+      const auto &callback = std::get<CompleteCallback>(task_info);
 
       auto status = worker(task_info);
       callback(id, status);
index 4701418..9aace49 100644 (file)
@@ -263,7 +263,7 @@ void Exporter::saveTflResult(
   assert(strides.size() == POOLING2D_DIM);
   auto poolSize = std::get<std::vector<props::PoolSize>>(props);
   assert(poolSize.size() == POOLING2D_DIM);
-  auto padding = std::get<props::Padding2D>(props).get();
+  const auto &padding = std::get<props::Padding2D>(props).get();
   assert(padding == "same" || padding == "valid");
 
   switch (poolingType.get()) {