sched/deadline: Remove superfluous rq clock update in push_dl_task()
authorHao Jia <jiahao.os@bytedance.com>
Sat, 30 Apr 2022 08:58:43 +0000 (16:58 +0800)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 11 May 2022 14:27:12 +0000 (16:27 +0200)
The change to call update_rq_clock() before activate_task()
commit 840d719604b0 ("sched/deadline: Update rq_clock of later_rq
when pushing a task") is no longer needed since commit f4904815f97a
("sched/deadline: Fix double accounting of rq/running bw in push & pull")
removed the add_running_bw() before the activate_task().

So we remove some comments that are no longer needed and update
rq clock in activate_task().

Signed-off-by: Hao Jia <jiahao.os@bytedance.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com>
Link: https://lore.kernel.org/r/20220430085843.62939-3-jiahao.os@bytedance.com
kernel/sched/deadline.c

index 0ad2818..936817a 100644 (file)
@@ -2318,13 +2318,7 @@ retry:
 
        deactivate_task(rq, next_task, 0);
        set_task_cpu(next_task, later_rq->cpu);
-
-       /*
-        * Update the later_rq clock here, because the clock is used
-        * by the cpufreq_update_util() inside __add_running_bw().
-        */
-       update_rq_clock(later_rq);
-       activate_task(later_rq, next_task, ENQUEUE_NOCLOCK);
+       activate_task(later_rq, next_task, 0);
        ret = 1;
 
        resched_curr(later_rq);