thunderbolt: Add the missed ida_simple_remove() in ring_request_msix()

ring_request_msix() misses to call ida_simple_remove() in an error path.
Add a label 'err_ida_remove' and jump to it.

Fixes: 046bee1f9ab8 ("thunderbolt: Add MSI-X support")
Cc: stable@vger.kernel.org
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c
index 3f79baa..e29ac3e 100644 (file)
--- a/drivers/thunderbolt/nhi.c
+++ b/drivers/thunderbolt/nhi.c
@@ -406,12 +406,23 @@ static int ring_request_msix(struct tb_ring *ring, bool no_suspend)
 
        ring->vector = ret;
 
-       ring->irq = pci_irq_vector(ring->nhi->pdev, ring->vector);
-       if (ring->irq < 0)
-               return ring->irq;
+       ret = pci_irq_vector(ring->nhi->pdev, ring->vector);
+       if (ret < 0)
+               goto err_ida_remove;
+
+       ring->irq = ret;
 
        irqflags = no_suspend ? IRQF_NO_SUSPEND : 0;
-       return request_irq(ring->irq, ring_msix, irqflags, "thunderbolt", ring);
+       ret = request_irq(ring->irq, ring_msix, irqflags, "thunderbolt", ring);
+       if (ret)
+               goto err_ida_remove;
+
+       return 0;
+
+err_ida_remove:
+       ida_simple_remove(&nhi->msix_ida, ring->vector);
+
+       return ret;
 }
 
 static void ring_release_msix(struct tb_ring *ring)