lib: utils: check correct value in fdt_node_offset_by_compatible

After calling fdt_node_offset_by_compatible() we must check its return
value and not an unrelated value.

Addresses-Coverity-ID: 1584993 Logically dead code
Fixes: 67ce5a763cfb ("platform: generic: Add support for specify coldboot harts in DT")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Anup Patel <anup@brainfault.org>

diff --git a/lib/utils/fdt/fdt_fixup.c b/lib/utils/fdt/fdt_fixup.c
index 194e55b3a82f616a0c12ad6e2221d55b0ff31933..974b1b883eb4ff63448e65d67d0c2fb51b597e47 100644 (file)
--- a/lib/utils/fdt/fdt_fixup.c
+++ b/lib/utils/fdt/fdt_fixup.c
@@ -394,7 +394,7 @@ void fdt_config_fixup(void *fdt)
                return;
 
        config_offset = fdt_node_offset_by_compatible(fdt, chosen_offset, "opensbi,config");
-       if (chosen_offset < 0)
+       if (config_offset < 0)
                return;
 
        fdt_nop_node(fdt, config_offset);