gio: don't assume that SOCK_CLOEXEC is supported whenever it's defined
authorJulien Cristau <jcristau@debian.org>
Thu, 15 Jul 2010 14:26:02 +0000 (15:26 +0100)
committerDan Winship <danw@gnome.org>
Thu, 15 Jul 2010 22:06:05 +0000 (18:06 -0400)
Just because SOCK_CLOEXEC was defined at build time doesn't mean the
kernel we're running on supports it.  So if socket() fails with EINVAL,
try again without the flag.

https://bugzilla.gnome.org/show_bug.cgi?id=624463

gio/gsocket.c

index e2ba788..5ab7778 100644 (file)
@@ -455,9 +455,11 @@ g_socket_create_socket (GSocketFamily   family,
     }
 
 #ifdef SOCK_CLOEXEC
-  native_type |= SOCK_CLOEXEC;
+  fd = socket (family, native_type | SOCK_CLOEXEC, protocol);
+  /* It's possible that libc has SOCK_CLOEXEC but the kernel does not */
+  if (fd < 0 && errno == EINVAL)
 #endif
-  fd = socket (family, native_type, protocol);
+    fd = socket (family, native_type, protocol);
 
   if (fd < 0)
     {