ublk: remove unnecessary NULL check in ublk_rq_has_data()
authorZiyang Zhang <ZiyangZhang@linux.alibaba.com>
Tue, 7 Feb 2023 07:08:37 +0000 (15:08 +0800)
committerJens Axboe <axboe@kernel.dk>
Tue, 7 Feb 2023 14:21:31 +0000 (07:21 -0700)
bio_has_data() allows a NULL bio so the NULL check in
ublk_rq_has_data() is unnecessary.

Signed-off-by: Ziyang Zhang <ZiyangZhang@linux.alibaba.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20230207070839.370817-2-ZiyangZhang@linux.alibaba.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c

index c932e9e..55fccce 100644 (file)
@@ -322,7 +322,7 @@ static inline struct ublk_queue *ublk_get_queue(struct ublk_device *dev,
 
 static inline bool ublk_rq_has_data(const struct request *rq)
 {
-       return rq->bio && bio_has_data(rq->bio);
+       return bio_has_data(rq->bio);
 }
 
 static inline struct ublksrv_io_desc *ublk_get_iod(struct ublk_queue *ubq,