store media number in memory, db access is too slow when used as sort key

diff --git a/zypp/repo/cached/PackageImpl.cc b/zypp/repo/cached/PackageImpl.cc
index b47c9f2..2587dc4 100644 (file)
--- a/zypp/repo/cached/PackageImpl.cc
+++ b/zypp/repo/cached/PackageImpl.cc
@@ -136,7 +136,11 @@ Changelog PackageImpl::changelog() const
 
 unsigned PackageImpl::mediaNr() const
 {
-  return _repository->resolvableQuery().queryNumericAttribute( _id, cache::attrPackageLocationMediaNr() );
+  if ( _mnr == (unsigned)-1 )
+  {
+    _mnr = _repository->resolvableQuery().queryNumericAttribute( _id, cache::attrPackageLocationMediaNr() );
+  }
+  return _mnr;
 }
 
 ByteCount PackageImpl::downloadSize() const

diff --git a/zypp/repo/cached/PackageImpl.h b/zypp/repo/cached/PackageImpl.h
index a8f47f1..a490a8e 100644 (file)
--- a/zypp/repo/cached/PackageImpl.h
+++ b/zypp/repo/cached/PackageImpl.h
@@ -82,6 +82,8 @@ namespace cached
   private:
     repo::cached::RepoImpl::Ptr _repository;
     data::RecordId _id;
+
+    mutable DefaultIntegral<unsigned,(unsigned)-1> _mnr;
   };
   /////////////////////////////////////////////////////////////////
 } // namespace cached

diff --git a/zypp/repo/cached/SrcPackageImpl.cc b/zypp/repo/cached/SrcPackageImpl.cc
index 1436a65..13cbeb9 100644 (file)
--- a/zypp/repo/cached/SrcPackageImpl.cc
+++ b/zypp/repo/cached/SrcPackageImpl.cc
@@ -99,7 +99,11 @@ Date SrcPackageImpl::installtime() const
 
 unsigned SrcPackageImpl::mediaNr() const
 {
-  return _repository->resolvableQuery().queryNumericAttribute( _id, cache::attrSrcPackageLocationMediaNr() );
+  if ( _mnr == (unsigned)-1 )
+  {
+    _mnr = _repository->resolvableQuery().queryNumericAttribute( _id, cache::attrSrcPackageLocationMediaNr() );
+  }
+  return _mnr;
 }
 
 ByteCount SrcPackageImpl::downloadSize() const

diff --git a/zypp/repo/cached/SrcPackageImpl.h b/zypp/repo/cached/SrcPackageImpl.h
index bab1152..43f8b9a 100644 (file)
--- a/zypp/repo/cached/SrcPackageImpl.h
+++ b/zypp/repo/cached/SrcPackageImpl.h
@@ -56,9 +56,12 @@ namespace cached
     virtual Date installtime() const;
 
     virtual OnMediaLocation location() const;
+
   private:
     repo::cached::RepoImpl::Ptr _repository;
     data::RecordId              _id;
+
+    mutable DefaultIntegral<unsigned,(unsigned)-1> _mnr;
   };
   /////////////////////////////////////////////////////////////////
 } // ns cached