media: dvb-frontends: rtl2832_sdr: Replace GFP_ATOMIC with GFP_KERNEL

rtl2832_sdr_submit_urbs(), rtl2832_sdr_alloc_stream_bufs(), and
rtl2832_sdr_alloc_urbs() are never called in atomic context.
They call usb_submit_urb(), usb_alloc_coherent() and usb_alloc_urb()
with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

diff --git a/drivers/media/dvb-frontends/rtl2832_sdr.c b/drivers/media/dvb-frontends/rtl2832_sdr.c
index c6e78d8..d448d9d 100644 (file)
--- a/drivers/media/dvb-frontends/rtl2832_sdr.c
+++ b/drivers/media/dvb-frontends/rtl2832_sdr.c
@@ -301,7 +301,7 @@ static int rtl2832_sdr_submit_urbs(struct rtl2832_sdr_dev *dev)
 
        for (i = 0; i < dev->urbs_initialized; i++) {
                dev_dbg(&pdev->dev, "submit urb=%d\n", i);
-               ret = usb_submit_urb(dev->urb_list[i], GFP_ATOMIC);
+               ret = usb_submit_urb(dev->urb_list[i], GFP_KERNEL);
                if (ret) {
                        dev_err(&pdev->dev,
                                "Could not submit urb no. %d - get them all back\n",
@@ -345,7 +345,7 @@ static int rtl2832_sdr_alloc_stream_bufs(struct rtl2832_sdr_dev *dev)
 
        for (dev->buf_num = 0; dev->buf_num < MAX_BULK_BUFS; dev->buf_num++) {
                dev->buf_list[dev->buf_num] = usb_alloc_coherent(dev->udev,
-                               BULK_BUFFER_SIZE, GFP_ATOMIC,
+                               BULK_BUFFER_SIZE, GFP_KERNEL,
                                &dev->dma_addr[dev->buf_num]);
                if (!dev->buf_list[dev->buf_num]) {
                        dev_dbg(&pdev->dev, "alloc buf=%d failed\n",
@@ -390,7 +390,7 @@ static int rtl2832_sdr_alloc_urbs(struct rtl2832_sdr_dev *dev)
        /* allocate the URBs */
        for (i = 0; i < MAX_BULK_BUFS; i++) {
                dev_dbg(&pdev->dev, "alloc urb=%d\n", i);
-               dev->urb_list[i] = usb_alloc_urb(0, GFP_ATOMIC);
+               dev->urb_list[i] = usb_alloc_urb(0, GFP_KERNEL);
                if (!dev->urb_list[i]) {
                        for (j = 0; j < i; j++)
                                usb_free_urb(dev->urb_list[j]);