xfs: fix uninitialized return values in scrub code
authorDarrick J. Wong <darrick.wong@oracle.com>
Mon, 6 Nov 2017 20:01:48 +0000 (12:01 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Thu, 9 Nov 2017 17:10:45 +0000 (09:10 -0800)
Fix smatch complaints about uninitialized return codes.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
fs/xfs/scrub/dir.c
fs/xfs/scrub/parent.c

index c8ca3fd..69e1efd 100644 (file)
@@ -748,7 +748,7 @@ xfs_scrub_directory(
        };
        size_t                          bufsize;
        loff_t                          oldpos;
-       int                             error;
+       int                             error = 0;
 
        if (!S_ISDIR(VFS_I(sc->ip)->i_mode))
                return -ENOENT;
index cc2b8f6..63a2533 100644 (file)
@@ -143,7 +143,7 @@ xfs_scrub_parent_validate(
        struct xfs_inode                *dp = NULL;
        xfs_nlink_t                     expected_nlink;
        xfs_nlink_t                     nlink;
-       int                             error;
+       int                             error = 0;
 
        *try_again = false;
 
@@ -258,7 +258,7 @@ xfs_scrub_parent(
        xfs_ino_t                       dnum;
        bool                            try_again;
        int                             tries = 0;
-       int                             error;
+       int                             error = 0;
 
        /*
         * If we're a directory, check that the '..' link points up to