staging: wlan-ng: Remove function hfa384x_dorrid_wait()
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Fri, 12 Jul 2019 06:27:58 +0000 (11:57 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 22 Jul 2019 05:34:11 +0000 (07:34 +0200)
Remove function hfa384x_dorrid_wait as it is only called once and it
does nothing except call hfa384x_dorrid.
Move contents of hfa384x_dorrid_wait to its only call site to maintain
functionality.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190712062807.9361-1-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wlan-ng/hfa384x_usb.c

index ab734534093b3c31c48e61e93db4821438a66565..4befc615d8e293ad4a888d7c2226e7f676971c6a 100644 (file)
@@ -834,14 +834,6 @@ hfa384x_docmd_async(struct hfa384x *hw,
        return hfa384x_docmd(hw, DOASYNC, cmd, cmdcb, usercb, usercb_data);
 }
 
-static inline int
-hfa384x_dorrid_wait(struct hfa384x *hw, u16 rid, void *riddata,
-                   unsigned int riddatalen)
-{
-       return hfa384x_dorrid(hw, DOWAIT,
-                             rid, riddata, riddatalen, NULL, NULL, NULL);
-}
-
 static inline int
 hfa384x_dorrid_async(struct hfa384x *hw,
                     u16 rid, void *riddata, unsigned int riddatalen,
@@ -2061,7 +2053,7 @@ exit_proc:
  */
 int hfa384x_drvr_getconfig(struct hfa384x *hw, u16 rid, void *buf, u16 len)
 {
-       return hfa384x_dorrid_wait(hw, rid, buf, len);
+       return hfa384x_dorrid(hw, DOWAIT, rid, buf, len, NULL, NULL, NULL);
 }
 
 /*----------------------------------------------------------------