ALSA: hda: cs35l56: Don't 'return ret' if ret is always zero
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Thu, 14 Sep 2023 14:08:52 +0000 (15:08 +0100)
committerTakashi Iwai <tiwai@suse.de>
Thu, 14 Sep 2023 14:29:43 +0000 (16:29 +0200)
The final return in cs35l56_hda_posture_get() was returning the
value of 'ret', but ret is always zero at this point. So this
can be a simple 'return 0'.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230914140852.7112-1-rf@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/cs35l56_hda.c

index 9e4976b..bc75865 100644 (file)
@@ -218,7 +218,7 @@ static int cs35l56_hda_posture_get(struct snd_kcontrol *kcontrol,
 
        ucontrol->value.integer.value[0] = pos;
 
-       return ret;
+       return 0;
 }
 
 static int cs35l56_hda_posture_put(struct snd_kcontrol *kcontrol,