s390/qeth: handle limited IPv4 broadcast in L3 TX path
authorJulian Wiedmann <jwi@linux.ibm.com>
Wed, 5 Jun 2019 11:48:48 +0000 (13:48 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 5 Jun 2019 18:48:57 +0000 (11:48 -0700)
When selecting the cast type of a neighbourless IPv4 skb (eg. on a raw
socket), qeth_l3 falls back to the packet's destination IP address.
For this case we should classify traffic sent to 255.255.255.255 as
broadcast.
This fixes DHCP requests, which were misclassified as unicast
(and for IQD interfaces thus ended up on the wrong HW queue).

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_l3_main.c

index 0271833..2df67ab 100644 (file)
@@ -1911,6 +1911,8 @@ static int qeth_l3_get_cast_type(struct sk_buff *skb)
        /* no neighbour (eg AF_PACKET), fall back to target's IP address ... */
        switch (qeth_get_ip_version(skb)) {
        case 4:
+               if (ipv4_is_lbcast(ip_hdr(skb)->daddr))
+                       return RTN_BROADCAST;
                return ipv4_is_multicast(ip_hdr(skb)->daddr) ?
                                RTN_MULTICAST : RTN_UNICAST;
        case 6: