scsi: smartpqi: Enhance controller offline notification
authorDavid Strahan <David.Strahan@microchip.com>
Thu, 24 Aug 2023 15:58:10 +0000 (10:58 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Aug 2023 02:54:21 +0000 (22:54 -0400)
Add a description for the reason the controller has been taken off-line.

Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
Reviewed-by: Scott Teel <scott.teel@microchip.com>
Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
Signed-off-by: David Strahan <David.Strahan@microchip.com>
Signed-off-by: Don Brace <don.brace@microchip.com>
Link: https://lore.kernel.org/r/20230824155812.789913-7-don.brace@microchip.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/smartpqi/smartpqi_init.c

index aacb40c..f1b3934 100644 (file)
@@ -9003,6 +9003,52 @@ static void pqi_ctrl_offline_worker(struct work_struct *work)
        pqi_take_ctrl_offline_deferred(ctrl_info);
 }
 
+static char *pqi_ctrl_shutdown_reason_to_string(enum pqi_ctrl_shutdown_reason ctrl_shutdown_reason)
+{
+       char *string;
+
+       switch (ctrl_shutdown_reason) {
+       case PQI_IQ_NOT_DRAINED_TIMEOUT:
+               string = "inbound queue not drained timeout";
+               break;
+       case PQI_LUN_RESET_TIMEOUT:
+               string = "LUN reset timeout";
+               break;
+       case PQI_IO_PENDING_POST_LUN_RESET_TIMEOUT:
+               string = "I/O pending timeout after LUN reset";
+               break;
+       case PQI_NO_HEARTBEAT:
+               string = "no controller heartbeat detected";
+               break;
+       case PQI_FIRMWARE_KERNEL_NOT_UP:
+               string = "firmware kernel not ready";
+               break;
+       case PQI_OFA_RESPONSE_TIMEOUT:
+               string = "OFA response timeout";
+               break;
+       case PQI_INVALID_REQ_ID:
+               string = "invalid request ID";
+               break;
+       case PQI_UNMATCHED_REQ_ID:
+               string = "unmatched request ID";
+               break;
+       case PQI_IO_PI_OUT_OF_RANGE:
+               string = "I/O queue producer index out of range";
+               break;
+       case PQI_EVENT_PI_OUT_OF_RANGE:
+               string = "event queue producer index out of range";
+               break;
+       case PQI_UNEXPECTED_IU_TYPE:
+               string = "unexpected IU type";
+               break;
+       default:
+               string = "unknown reason";
+               break;
+       }
+
+       return string;
+}
+
 static void pqi_take_ctrl_offline(struct pqi_ctrl_info *ctrl_info,
        enum pqi_ctrl_shutdown_reason ctrl_shutdown_reason)
 {
@@ -9015,7 +9061,9 @@ static void pqi_take_ctrl_offline(struct pqi_ctrl_info *ctrl_info,
        if (!pqi_disable_ctrl_shutdown)
                sis_shutdown_ctrl(ctrl_info, ctrl_shutdown_reason);
        pci_disable_device(ctrl_info->pci_dev);
-       dev_err(&ctrl_info->pci_dev->dev, "controller offline\n");
+       dev_err(&ctrl_info->pci_dev->dev,
+               "controller offline: reason code 0x%x (%s)\n",
+               ctrl_shutdown_reason, pqi_ctrl_shutdown_reason_to_string(ctrl_shutdown_reason));
        schedule_work(&ctrl_info->ctrl_offline_work);
 }