Feedback on r214189, no functionality change.

llvm-svn: 214240

diff --git a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
index d0958c0..f5b8dd7 100644 (file)
--- a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
@@ -473,7 +473,7 @@ DIE *DwarfDebug::createScopeChildrenDIE(
     // If we have more than one elements and the last one is null, it is a
     // variadic function.
     if (FnArgs.getNumElements() > 1 &&
-        !resolve(FnArgs.getElement(FnArgs.getNumElements() - 1)))
+        !FnArgs.getElement(FnArgs.getNumElements() - 1))
       Children.push_back(
           make_unique<DIE>(dwarf::DW_TAG_unspecified_parameters));
   }

diff --git a/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp b/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
index f49eaca..2139ffc 100644 (file)
--- a/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
@@ -1168,7 +1168,7 @@ void DwarfUnit::constructTypeDIE(DIE &Buffer, DICompositeType CTy) {
 
     bool isPrototyped = true;
     if (Elements.getNumElements() == 2 &&
-        !resolve(Elements.getElement(1)))
+        !Elements.getElement(1))
       isPrototyped = false;
 
     constructSubprogramArguments(Buffer, Elements);

diff --git a/llvm/lib/IR/DIBuilder.cpp b/llvm/lib/IR/DIBuilder.cpp
index 2903b9d..04a3ea4 100644 (file)
--- a/llvm/lib/IR/DIBuilder.cpp
+++ b/llvm/lib/IR/DIBuilder.cpp
@@ -876,7 +876,7 @@ void DIBuilder::retainType(DIType T) {
 /// createUnspecifiedParameter - Create unspeicified type descriptor
 /// for the subroutine type.
 DIBasicType DIBuilder::createUnspecifiedParameter() {
-  return DIBasicType(nullptr);
+  return DIBasicType();
 }
 
 /// createForwardDecl - Create a temporary forward-declared type that