[lldb] Remove scoped timer from high firing and fast running SymbolFileDWARF::FindFun...
authorDave Lee <davelee.com@gmail.com>
Thu, 29 Sep 2022 23:23:22 +0000 (16:23 -0700)
committerDave Lee <davelee.com@gmail.com>
Sat, 1 Oct 2022 16:58:03 +0000 (09:58 -0700)
Profiles show that `SymbolFileDWARF::FindFunctions` is both high firing (many thousands of calls) and fast running (35 µs mean).

Timers like this are noise and load for profiling systems, and can be removed.

rdar://100326595

Differential Revision: https://reviews.llvm.org/D134922

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

index a9d6974..348b0e5 100644 (file)
@@ -2355,8 +2355,6 @@ void SymbolFileDWARF::FindFunctions(const Module::LookupInfo &lookup_info,
   std::lock_guard<std::recursive_mutex> guard(GetModuleMutex());
   ConstString name = lookup_info.GetLookupName();
   FunctionNameType name_type_mask = lookup_info.GetNameTypeMask();
-  LLDB_SCOPED_TIMERF("SymbolFileDWARF::FindFunctions (name = '%s')",
-                     name.AsCString());
 
   // eFunctionNameTypeAuto should be pre-resolved by a call to
   // Module::LookupInfo::LookupInfo()