ethtool: netlink: Slightly simplify 'ethnl_features_to_bitmap()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 28 Nov 2021 11:03:30 +0000 (12:03 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 30 Nov 2021 04:16:46 +0000 (20:16 -0800)
The 'dest' bitmap is fully initialized by the 'for' loop, so there is no
need to explicitly reset it.

This also makes this function in line with 'ethnl_features_to_bitmap32()'
which does not clear the destination before writing it.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/17fca158231c6f03689bd891254f0dd1f4e84cb8.1638091829.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/features.c

index 1c9f4df..2e7331b 100644 (file)
@@ -136,7 +136,6 @@ static void ethnl_features_to_bitmap(unsigned long *dest, netdev_features_t val)
        const unsigned int words = BITS_TO_LONGS(NETDEV_FEATURE_COUNT);
        unsigned int i;
 
-       bitmap_zero(dest, NETDEV_FEATURE_COUNT);
        for (i = 0; i < words; i++)
                dest[i] = (unsigned long)(val >> (i * BITS_PER_LONG));
 }