ceph: Use kcalloc for allocating multiple elements
authorKenneth Lee <klee33@uw.edu>
Fri, 19 Aug 2022 05:42:55 +0000 (22:42 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 Dec 2022 16:41:00 +0000 (17:41 +0100)
[ Upstream commit aa1d627207cace003163dee24d1c06fa4e910c6b ]

Prefer using kcalloc(a, b) over kzalloc(a * b) as this improves
semantics since kcalloc is intended for allocating an array of memory.

Signed-off-by: Kenneth Lee <klee33@uw.edu>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Stable-dep-of: 5bd76b8de5b7 ("ceph: fix NULL pointer dereference for req->r_session")
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/ceph/caps.c

index 883bb91..a6e2aaf 100644 (file)
@@ -2255,7 +2255,7 @@ retry:
                struct ceph_mds_request *req;
                int i;
 
-               sessions = kzalloc(max_sessions * sizeof(s), GFP_KERNEL);
+               sessions = kcalloc(max_sessions, sizeof(s), GFP_KERNEL);
                if (!sessions) {
                        err = -ENOMEM;
                        goto out;