Remove unused check
authorBoris Zanin <boris.zanin@mobica.com>
Sun, 16 May 2021 18:04:30 +0000 (20:04 +0200)
committerAlexander Galazin <Alexander.Galazin@arm.com>
Fri, 21 May 2021 09:09:51 +0000 (09:09 +0000)
This check is useless here. Remove it.

Also a year later there was a specification issue #1222 "Should
requiresDedicatedAllocation imply requiresDedicatedAllocation?"

That clarified this question and specification now contains
following paragraph totally invalidating this check:

When the implementation sets requiresDedicatedAllocation to VK_TRUE,
it must also set prefersDedicatedAllocation to VK_TRUE.

Update tests:
 * dEQP-VK.memory.requirements.dedicated_allocation.buffer.*
 * dEQP-VK.memory.requirements.dedicated_allocation.image.*

Components: Vulkan

VK-GL-CTS issue: 391

VK-GL-CTS public issue: 267

Change-Id: I557d3c0fac752ec2f42db7e6dcd78787a0c69a26

external/vulkancts/modules/vulkan/memory/vktMemoryRequirementsTests.cpp

index acd0636..d2e3987 100644 (file)
@@ -585,9 +585,6 @@ void BufferMemoryRequirementsDedicatedAllocation::verifyMemoryRequirements (tcu:
 
        result.check(m_currentTestRequiresDedicatedAllocation == VK_FALSE,
                "Regular (non-shared) objects must not require dedicated allocations");
-
-       result.check(m_currentTestPrefersDedicatedAllocation == VK_FALSE || m_currentTestPrefersDedicatedAllocation == VK_FALSE,
-               "Preferred and required flags for dedicated memory cannot be set to true at the same time");
 }
 
 
@@ -1478,9 +1475,6 @@ void ImageMemoryRequirementsDedicatedAllocation::verifyMemoryRequirements (tcu::
 
        result.check(m_currentTestRequiresDedicatedAllocation == VK_FALSE,
                "Test design expects m_currentTestRequiresDedicatedAllocation to be false");
-
-       result.check(m_currentTestPrefersDedicatedAllocation == VK_FALSE || m_currentTestPrefersDedicatedAllocation == VK_FALSE,
-               "Preferred and required flags for dedicated memory cannot be set to true at the same time");
 }
 
 void populateCoreTestGroup (tcu::TestCaseGroup* group)