Always use lowercase signal names in generated C code, patch by

2008-10-03  Jürg Billeter  <j@bitron.ch>

	* vala/valasignal.vala:
	* gobject/valaccodetypesymbolbinding.vala:

	Always use lowercase signal names in generated C code,
	patch by Marc-André Lureau, fixes bug 549507

svn path=/trunk/; revision=1819

diff --git a/ChangeLog b/ChangeLog
index 35f422c..266934a 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
 2008-10-03  Jürg Billeter  <j@bitron.ch>
 
+       * vala/valasignal.vala:
+       * gobject/valaccodetypesymbolbinding.vala:
+
+       Always use lowercase signal names in generated C code,
+       patch by Marc-André Lureau, fixes bug 549507
+
+2008-10-03  Jürg Billeter  <j@bitron.ch>
+
        * vala/valaclass.vala:
        * vala/valainterfacewriter.vala:
        * vala/valatypesymbol.vala:

diff --git a/gobject/valaccodetypesymbolbinding.vala b/gobject/valaccodetypesymbolbinding.vala
index 1b991e3..821ff65 100644 (file)
--- a/gobject/valaccodetypesymbolbinding.vala
+++ b/gobject/valaccodetypesymbolbinding.vala
@@ -203,7 +203,7 @@ public abstract class Vala.CCodeTypeSymbolBinding : CCodeBinding {
 
        public CCodeFunctionCall get_signal_creation (Signal sig, TypeSymbol type) {    
                var csignew = new CCodeFunctionCall (new CCodeIdentifier ("g_signal_new"));
-               csignew.add_argument (new CCodeConstant ("\"%s\"".printf (sig.name)));
+               csignew.add_argument (new CCodeConstant ("\"%s\"".printf (sig.get_cname ())));
                csignew.add_argument (new CCodeIdentifier (type.get_type_id ()));
                csignew.add_argument (new CCodeConstant ("G_SIGNAL_RUN_LAST"));
                csignew.add_argument (new CCodeConstant ("0"));

diff --git a/vala/valasignal.vala b/vala/valasignal.vala
index b7a2ce0..c09ea4e 100644 (file)
--- a/vala/valasignal.vala
+++ b/vala/valasignal.vala
@@ -124,7 +124,7 @@ public class Vala.Signal : Member, Lockable {
         */
        public string get_cname () {
                if (cname == null) {
-                       cname = name;
+                       cname = camel_case_to_lower_case (name);
                }
                return cname;
        }