ARM: OMAP4: PM: Use custom omap_do_wfi() for default idle.
authorSantosh Shilimkar <santosh.shilimkar@ti.com>
Mon, 18 Jul 2011 06:55:10 +0000 (12:25 +0530)
committerKevin Hilman <khilman@ti.com>
Thu, 8 Dec 2011 19:29:00 +0000 (11:29 -0800)
Default arch_idle() isn't good enough for OMAP4 because of aync bridge errata
and necessity of NOPs post WFI to avoid speculative prefetch aborts.
Hence Use OMAP4 custom omap_do_wfi() hook for default idle.

Later in the series, async bridge errata work-around patch updates the
omap_do_wfi() with necessary interconnects barriers.

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Jean Pihet <j-pihet@ti.com>
Reviewed-by: Kevin Hilman <khilman@ti.com>
Tested-by: Vishwanath BS <vishwanath.bs@ti.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>
arch/arm/mach-omap2/pm44xx.c

index 781aadf..72c7450 100644 (file)
@@ -108,6 +108,24 @@ static int __init pwrdms_setup(struct powerdomain *pwrdm, void *unused)
 }
 
 /**
+ * omap_default_idle - OMAP4 default ilde routine.'
+ *
+ * Implements OMAP4 memory, IO ordering requirements which can't be addressed
+ * with default arch_idle() hook. Used by all CPUs with !CONFIG_CPUIDLE and
+ * by secondary CPU with CONFIG_CPUIDLE.
+ */
+static void omap_default_idle(void)
+{
+       local_irq_disable();
+       local_fiq_disable();
+
+       omap_do_wfi();
+
+       local_fiq_enable();
+       local_irq_enable();
+}
+
+/**
  * omap4_pm_init - Init routine for OMAP4 PM
  *
  * Initializes all powerdomain and clockdomain target states
@@ -175,6 +193,9 @@ static int __init omap4_pm_init(void)
        suspend_set_ops(&omap_pm_ops);
 #endif /* CONFIG_SUSPEND */
 
+       /* Overwrite the default arch_idle() */
+       pm_idle = omap_default_idle;
+
 err2:
        return ret;
 }