IB/hfi1: Add missing break in switch statement
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 21 Feb 2019 01:02:33 +0000 (19:02 -0600)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 21 Feb 2019 21:08:12 +0000 (14:08 -0700)
Fix the following warning by adding a missing break:

drivers/infiniband/hw/hfi1/tid_rdma.c: In function ‘hfi1_tid_rdma_wqe_interlock’:
drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   switch (prev->wr.opcode) {
   ^~~~~~
drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here
  case IB_WR_RDMA_READ:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and other requests")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kaike Wan <Kaike.wan@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hfi1/tid_rdma.c

index bc2ff83..fdda33a 100644 (file)
@@ -3256,6 +3256,7 @@ bool hfi1_tid_rdma_wqe_interlock(struct rvt_qp *qp, struct rvt_swqe *wqe)
                default:
                        break;
                }
+               break;
        case IB_WR_RDMA_READ:
                if (prev->wr.opcode != IB_WR_TID_RDMA_WRITE)
                        break;