scsi: qla2xxx: Fix stuck session in gpdb

Fix stuck sessions in get port database. When a thread is in the process of
re-establishing a session, a flag is set to prevent multiple threads /
triggers from doing the same task. This flag was left on, where any attempt
to relogin was locked out. Clear this flag, if the attempt has failed.

Link: https://lore.kernel.org/r/20220110050218.3958-4-njavali@marvell.com
Cc: stable@vger.kernel.org
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 38c11b7..0b641a8 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -1332,9 +1332,9 @@ int qla24xx_async_gpdb(struct scsi_qla_host *vha, fc_port_t *fcport, u8 opt)
        if (!vha->flags.online || (fcport->flags & FCF_ASYNC_SENT) ||
            fcport->loop_id == FC_NO_LOOP_ID) {
                ql_log(ql_log_warn, vha, 0xffff,
-                   "%s: %8phC - not sending command.\n",
-                   __func__, fcport->port_name);
-               return rval;
+                   "%s: %8phC online %d flags %x - not sending command.\n",
+                   __func__, fcport->port_name, vha->flags.online, fcport->flags);
+               goto done;
        }
 
        sp = qla2x00_get_sp(vha, fcport, GFP_KERNEL);