media: usb: cx231xx-417: fix a memory leak bug
authorWenwen Wang <wenwen@cs.uga.edu>
Sat, 17 Aug 2019 06:14:54 +0000 (03:14 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 26 Aug 2019 13:40:17 +0000 (10:40 -0300)
In cx231xx_load_firmware(), 'p_buffer' is allocated through vmalloc() to
hold the firmware. However, after the usage, it is not deallocated, leading
to a memory leak bug.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/usb/cx231xx/cx231xx-417.c

index 3062437..6d218a0 100644 (file)
@@ -1051,6 +1051,7 @@ static int cx231xx_load_firmware(struct cx231xx *dev)
        p_current_fw = p_fw;
        vfree(p_current_fw);
        p_current_fw = NULL;
+       vfree(p_buffer);
        uninitGPIO(dev);
        release_firmware(firmware);
        dprintk(1, "Firmware upload successful.\n");