Bluetooth: MGMT: Fix error report for ADD_EXT_ADV_PARAMS
authorInga Stotland <inga.stotland@intel.com>
Sat, 22 Oct 2022 00:48:56 +0000 (17:48 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:28 +0000 (13:32 +0100)
[ Upstream commit 3b1c7c00b8c22b3cb79532252c59eb0b287bb86d ]

When validating the parameter length for MGMT_OP_ADD_EXT_ADV_PARAMS
command, use the correct op code in error status report:
was MGMT_OP_ADD_ADVERTISING, changed to MGMT_OP_ADD_EXT_ADV_PARAMS.

Fixes: 12410572833a2 ("Bluetooth: Break add adv into two mgmt commands")
Signed-off-by: Inga Stotland <inga.stotland@intel.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/bluetooth/mgmt.c

index a92e7e485febab36fb6de3525710bdea79025011..0dd30a3beb77635ed29b9ec1fbd257f3456db840 100644 (file)
@@ -8859,7 +8859,7 @@ static int add_ext_adv_params(struct sock *sk, struct hci_dev *hdev,
         * extra parameters we don't know about will be ignored in this request.
         */
        if (data_len < MGMT_ADD_EXT_ADV_PARAMS_MIN_SIZE)
-               return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_ADVERTISING,
+               return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_EXT_ADV_PARAMS,
                                       MGMT_STATUS_INVALID_PARAMS);
 
        flags = __le32_to_cpu(cp->flags);