ALSA: mixart: Mark expected switch fall-through
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 8 Aug 2018 22:11:48 +0000 (17:11 -0500)
committerTakashi Iwai <tiwai@suse.de>
Thu, 9 Aug 2018 06:52:04 +0000 (08:52 +0200)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case, I replaced the code comment with
a proper "fall through" annotation, which is what GCC is expecting
to find.

Addresses-Coverity-ID: 114889 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/mixart/mixart_core.c

index 46c292b52fd6c19b041e0d69eb357a21bc4684ee..71776bfe04858ab9cdf9343b922af39859a2e71e 100644 (file)
@@ -540,7 +540,7 @@ irqreturn_t snd_mixart_threaded_irq(int irq, void *dev_id)
                                dev_err(&mgr->pci->dev,
                                        "canceled notification %x !\n", msg);
                        }
-                       /* no break, continue ! */
+                       /* fall through */
                case MSG_TYPE_ANSWER:
                        /* answer or notification to a message we are waiting for*/
                        mutex_lock(&mgr->msg_lock);