bnxt_en: fix stored FW_PSID version masks
authorEdwin Peer <edwin.peer@broadcom.com>
Sun, 5 Sep 2021 18:10:55 +0000 (14:10 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 10:28:05 +0000 (12:28 +0200)
[ Upstream commit 1656db67233e4259281d2ac35b25f712edbbc20b ]

The FW_PSID version components are 8 bits wide, not 4.

Fixes: db28b6c77f40 ("bnxt_en: Fix devlink info's stored fw.psid version format.")
Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

index 8b0e916..2bd476a 100644 (file)
@@ -474,8 +474,8 @@ static int bnxt_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
        if (BNXT_PF(bp) && !bnxt_hwrm_get_nvm_cfg_ver(bp, &nvm_cfg_ver)) {
                u32 ver = nvm_cfg_ver.vu32;
 
-               sprintf(buf, "%d.%d.%d", (ver >> 16) & 0xf, (ver >> 8) & 0xf,
-                       ver & 0xf);
+               sprintf(buf, "%d.%d.%d", (ver >> 16) & 0xff, (ver >> 8) & 0xff,
+                       ver & 0xff);
                rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_STORED,
                                      DEVLINK_INFO_VERSION_GENERIC_FW_PSID,
                                      buf);