net: lantiq_etop: add missing comment for wmb()
authorAleksander Jan Bajkowski <olek2@wp.pl>
Tue, 28 Dec 2021 21:49:10 +0000 (22:49 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 28 Dec 2021 23:59:55 +0000 (15:59 -0800)
This patch adds the missing code comment for memory barrier
call and fixes checkpatch warning:

WARNING: memory barrier without comment
+ wmb();

Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Link: https://lore.kernel.org/r/20211228214910.70810-1-olek2@wp.pl
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/lantiq_etop.c

index 14059e1..6f04927 100644 (file)
@@ -498,6 +498,7 @@ ltq_etop_tx(struct sk_buff *skb, struct net_device *dev)
        spin_lock_irqsave(&priv->lock, flags);
        desc->addr = ((unsigned int) dma_map_single(&priv->pdev->dev, skb->data, len,
                                                DMA_TO_DEVICE)) - byte_offset;
+       /* Make sure the address is written before we give it to HW */
        wmb();
        desc->ctl = LTQ_DMA_OWN | LTQ_DMA_SOP | LTQ_DMA_EOP |
                LTQ_DMA_TX_OFFSET(byte_offset) | (len & LTQ_DMA_SIZE_MASK);