net/smc: Replace zero-length array with flexible-array member
authorGustavo A. R. Silva <gustavoars@kernel.org>
Tue, 27 Oct 2020 06:33:56 +0000 (01:33 -0500)
committerGustavo A. R. Silva <gustavoars@kernel.org>
Fri, 30 Oct 2020 21:57:42 +0000 (16:57 -0500)
There is a regular need in the kernel to provide a way to declare having a
dynamically sized set of trailing elements in a structure. Kernel code should
always use “flexible array members”[1] for these cases. The older style of
one-element or zero-length arrays should no longer be used[2].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.9/process/deprecated.html#zero-length-and-one-element-arrays

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
net/smc/smc_clc.h

index b3f46ab..c579d1d 100644 (file)
@@ -124,7 +124,7 @@ struct smc_clc_v2_extension {
        struct smc_clnt_opts_area_hdr hdr;
        u8 roce[16];            /* RoCEv2 GID */
        u8 reserved[16];
-       u8 user_eids[0][SMC_MAX_EID_LEN];
+       u8 user_eids[][SMC_MAX_EID_LEN];
 };
 
 struct smc_clc_msg_proposal_prefix {   /* prefix part of clc proposal message*/
@@ -143,7 +143,7 @@ struct smc_clc_msg_smcd {   /* SMC-D GID information */
 struct smc_clc_smcd_v2_extension {
        u8 system_eid[SMC_MAX_EID_LEN];
        u8 reserved[16];
-       struct smc_clc_smcd_gid_chid gidchid[0];
+       struct smc_clc_smcd_gid_chid gidchid[];
 };
 
 struct smc_clc_msg_proposal {  /* clc proposal message sent by Linux */