ASoC: soc-pcm: fix the return value in dpcm_apply_symmetry()
authorJaroslav Kysela <perex@perex.cz>
Mon, 14 Jun 2021 07:17:46 +0000 (09:17 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:05:43 +0000 (16:05 +0200)
[ Upstream commit 12ffd726824a2f52486f72338b6fd3244b512959 ]

In case, where the loops are not executed for a reason, the uninitialized
variable 'err' is returned to the caller. Make code fully predictible
and assign zero in the declaration.

Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Cc: Mark Brown <broonie@kernel.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/20210614071746.1787072-1-perex@perex.cz
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/soc-pcm.c

index 91bf339581590a32c4a10befe9c5a95a35d478d4..8b8a9aca2912ffae131c22450064177997cb0194 100644 (file)
@@ -1738,7 +1738,7 @@ static int dpcm_apply_symmetry(struct snd_pcm_substream *fe_substream,
        struct snd_soc_dpcm *dpcm;
        struct snd_soc_pcm_runtime *fe = asoc_substream_to_rtd(fe_substream);
        struct snd_soc_dai *fe_cpu_dai;
-       int err;
+       int err = 0;
        int i;
 
        /* apply symmetry for FE */