media: pci: cx23885: Replace mdelay() with msleep() in cx23885_reset()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 Jul 2018 03:18:46 +0000 (23:18 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 27 Jul 2018 12:14:10 +0000 (08:14 -0400)
cx23885_reset() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/pci/cx23885/cx23885-core.c

index 94b996f..39804d8 100644 (file)
@@ -667,7 +667,7 @@ static void cx23885_reset(struct cx23885_dev *dev)
 
        /* clear dma in progress */
        cx23885_clear_bridge_error(dev);
-       mdelay(100);
+       msleep(100);
 
        cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH01],
                720*4, 0);