orinoco: Delete an unnecessary check before the function call "kfree"
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 4 Feb 2015 18:53:11 +0000 (19:53 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 6 Feb 2015 06:50:24 +0000 (08:50 +0200)
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/orinoco/main.c

index 38ec8d1..c410180 100644 (file)
@@ -2342,7 +2342,7 @@ void free_orinocodev(struct orinoco_private *priv)
        list_for_each_entry_safe(sd, sdtemp, &priv->scan_list, list) {
                list_del(&sd->list);
 
-               if ((sd->len > 0) && sd->buf)
+               if (sd->len > 0)
                        kfree(sd->buf);
                kfree(sd);
        }