[InstCombine] foldAggregateConstructionIntoAggregateReuse(): use InstCombiner::replac...

We really shouldn't use RAUW in InstCombine
because we should consistently update Worklist to avoid extra iterations.

diff --git a/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp b/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
index 5cd1822..14de00f 100644 (file)
--- a/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
@@ -975,7 +975,7 @@ Instruction *InstCombinerImpl::foldAggregateConstructionIntoAggregateReuse(
     PHI->addIncoming(SourceAggregates[Pred], Pred);
 
   ++NumAggregateReconstructionsSimplified;
-  OrigIVI.replaceAllUsesWith(PHI);
+  replaceInstUsesWith(OrigIVI, PHI);
 
   // Just signal that the fold happened, we've already inserted instructions.
   return &OrigIVI;