Elementary: cnp - check on NULL data in elm_drag_start
authorArtem Popov <artem.popov@samsung.com>
Mon, 4 Jul 2016 01:49:55 +0000 (10:49 +0900)
committerJean-Philippe Andre <jp.andre@samsung.com>
Mon, 4 Jul 2016 02:01:05 +0000 (11:01 +0900)
Summary:
check on NULL add in wayland elm_drag_start API
@fix

Test Plan: Call elm_grag_start with data = NULL under wayland

Reviewers: zmike, NikaWhite, jpeg

Reviewed By: NikaWhite, jpeg

Subscribers: bu5hm4n, myoungwoon, cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D4119

src/lib/elementary/elm_cnp.c

index a7f81ee..855e7d8 100644 (file)
@@ -3345,8 +3345,13 @@ _wl_elm_drag_start(Evas_Object *obj, Elm_Sel_Format format, const char *data,
 
    /* set the drag data used when a drop occurs */
    free(wl_cnp_selection.selbuf);
-   wl_cnp_selection.selbuf = strdup((char*)data);
-   wl_cnp_selection.buflen = strlen(wl_cnp_selection.selbuf);
+   wl_cnp_selection.buflen = 0;
+   wl_cnp_selection.selbuf = eina_strdup(data);
+
+   if (data)
+     {
+        wl_cnp_selection.buflen = strlen(wl_cnp_selection.selbuf);
+     }
 
    /* setup callback to notify if this object gets deleted */
    evas_object_event_callback_add(obj, EVAS_CALLBACK_DEL,