gpio: wm831x: Convert to use devm_kzalloc API
authorAxel Lin <axel.lin@gmail.com>
Sun, 2 Sep 2012 03:58:07 +0000 (11:58 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 4 Sep 2012 07:25:13 +0000 (09:25 +0200)
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-wm831x.c

index e56a216..b6eda35 100644 (file)
@@ -250,7 +250,8 @@ static int __devinit wm831x_gpio_probe(struct platform_device *pdev)
        struct wm831x_gpio *wm831x_gpio;
        int ret;
 
-       wm831x_gpio = kzalloc(sizeof(*wm831x_gpio), GFP_KERNEL);
+       wm831x_gpio = devm_kzalloc(&pdev->dev, sizeof(*wm831x_gpio),
+                                  GFP_KERNEL);
        if (wm831x_gpio == NULL)
                return -ENOMEM;
 
@@ -265,30 +266,20 @@ static int __devinit wm831x_gpio_probe(struct platform_device *pdev)
 
        ret = gpiochip_add(&wm831x_gpio->gpio_chip);
        if (ret < 0) {
-               dev_err(&pdev->dev, "Could not register gpiochip, %d\n",
-                       ret);
-               goto err;
+               dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
+               return ret;
        }
 
        platform_set_drvdata(pdev, wm831x_gpio);
 
        return ret;
-
-err:
-       kfree(wm831x_gpio);
-       return ret;
 }
 
 static int __devexit wm831x_gpio_remove(struct platform_device *pdev)
 {
        struct wm831x_gpio *wm831x_gpio = platform_get_drvdata(pdev);
-       int ret;
-
-       ret = gpiochip_remove(&wm831x_gpio->gpio_chip);
-       if (ret == 0)
-               kfree(wm831x_gpio);
 
-       return ret;
+       return  gpiochip_remove(&wm831x_gpio->gpio_chip);
 }
 
 static struct platform_driver wm831x_gpio_driver = {