usb: fotg210-hcd: Don't shadow error codes in store()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 20 Jan 2023 15:44:34 +0000 (17:44 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Jan 2023 17:12:58 +0000 (18:12 +0100)
kstrtox() along with regmap API can return different error codes based on
circumstances.

Don't shadow them when returning to the caller.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230120154437.22025-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/fotg210/fotg210-hcd.c

index 46752a7..5a934f5 100644 (file)
@@ -4702,8 +4702,10 @@ static ssize_t uframe_periodic_max_store(struct device *dev,
        ssize_t ret;
 
        fotg210 = hcd_to_fotg210(bus_to_hcd(dev_get_drvdata(dev)));
-       if (kstrtouint(buf, 0, &uframe_periodic_max) < 0)
-               return -EINVAL;
+
+       ret = kstrtouint(buf, 0, &uframe_periodic_max);
+       if (ret)
+               return ret;
 
        if (uframe_periodic_max < 100 || uframe_periodic_max >= 125) {
                fotg210_info(fotg210, "rejecting invalid request for uframe_periodic_max=%u\n",