serial: qcom_geni_serial: redundant initialization to variable line
authorColin Ian King <colin.king@canonical.com>
Fri, 23 Apr 2021 08:13:17 +0000 (09:13 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 14:20:51 +0000 (16:20 +0200)
The variable line being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Unused value")
Link: https://lore.kernel.org/r/20210423081317.318352-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/qcom_geni_serial.c

index 23d729e..463f84a 100644 (file)
@@ -1338,7 +1338,7 @@ static const struct uart_ops qcom_geni_uart_pops = {
 static int qcom_geni_serial_probe(struct platform_device *pdev)
 {
        int ret = 0;
-       int line = -1;
+       int line;
        struct qcom_geni_serial_port *port;
        struct uart_port *uport;
        struct resource *res;