PCI: Remove PCI_REASSIGN_ALL_RSRC use on arm and arm64
authorBjorn Helgaas <bhelgaas@google.com>
Thu, 30 Nov 2017 17:21:57 +0000 (11:21 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 19 Dec 2017 05:07:43 +0000 (23:07 -0600)
On arm, PCI_REASSIGN_ALL_RSRC is used only in pcibios_assign_all_busses(),
which helps decide whether to reconfigure bridge bus numbers.  It has
nothing to do with BAR assignments.  On arm64 and powerpc,
pcibios_assign_all_busses() tests PCI_REASSIGN_ALL_BUS, which makes more
sense.

Align arm with arm64 and powerpc, so they all use PCI_REASSIGN_ALL_BUS for
pcibios_assign_all_busses().

Remove PCI_REASSIGN_ALL_RSRC from the generic, Tegra, Versatile, and
R-Car drivers.  These drivers are used only on arm or arm64, where
PCI_REASSIGN_ALL_RSRC is not used after this change, so removing it
should have no effect.

No functional change intended.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Reviewed-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
arch/arm/include/asm/pci.h
arch/arm/kernel/bios32.c
drivers/pci/host/pci-host-common.c
drivers/pci/host/pci-tegra.c
drivers/pci/host/pci-versatile.c
drivers/pci/host/pcie-rcar.c

index 960d9dc..1f0de80 100644 (file)
@@ -10,10 +10,7 @@ extern unsigned long pcibios_min_io;
 extern unsigned long pcibios_min_mem;
 #define PCIBIOS_MIN_MEM pcibios_min_mem
 
-static inline int pcibios_assign_all_busses(void)
-{
-       return pci_has_flag(PCI_REASSIGN_ALL_RSRC);
-}
+#define pcibios_assign_all_busses()    pci_has_flag(PCI_REASSIGN_ALL_BUS)
 
 #ifdef CONFIG_PCI_DOMAINS
 static inline int pci_proc_domain(struct pci_bus *bus)
index 0cd0aef..ed46ca6 100644 (file)
@@ -527,7 +527,7 @@ void pci_common_init_dev(struct device *parent, struct hw_pci *hw)
        struct pci_sys_data *sys;
        LIST_HEAD(head);
 
-       pci_add_flags(PCI_REASSIGN_ALL_RSRC);
+       pci_add_flags(PCI_REASSIGN_ALL_BUS);
        if (hw->preinit)
                hw->preinit();
        pcibios_init_hw(parent, hw, &head);
index 44a47d4..c4b891c 100644 (file)
@@ -142,7 +142,7 @@ int pci_host_common_probe(struct platform_device *pdev,
 
        /* Do not reassign resources if probe only */
        if (!pci_has_flag(PCI_PROBE_ONLY))
-               pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
+               pci_add_flags(PCI_REASSIGN_ALL_BUS);
 
        list_splice_init(&resources, &bridge->windows);
        bridge->dev.parent = dev;
index f9d3960..ee19376 100644 (file)
@@ -2382,7 +2382,7 @@ static int tegra_pcie_probe(struct platform_device *pdev)
 
        tegra_pcie_enable_ports(pcie);
 
-       pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
+       pci_add_flags(PCI_REASSIGN_ALL_BUS);
        host->busnr = pcie->busn.start;
        host->dev.parent = &pdev->dev;
        host->ops = &tegra_pcie_ops;
index d417aca..2a2dfcd 100644 (file)
@@ -202,7 +202,7 @@ static int versatile_pci_probe(struct platform_device *pdev)
        writel(0, versatile_cfg_base[0] + PCI_INTERRUPT_LINE);
 
        pci_add_flags(PCI_ENABLE_PROC_DOMAINS);
-       pci_add_flags(PCI_REASSIGN_ALL_BUS | PCI_REASSIGN_ALL_RSRC);
+       pci_add_flags(PCI_REASSIGN_ALL_BUS);
 
        list_splice_init(&pci_res, &bridge->windows);
        bridge->dev.parent = dev;
index 52ab3cb..2ef5ff9 100644 (file)
@@ -459,7 +459,7 @@ static int rcar_pcie_enable(struct rcar_pcie *pcie)
 
        rcar_pcie_setup(&bridge->windows, pcie);
 
-       pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
+       pci_add_flags(PCI_REASSIGN_ALL_BUS);
 
        bridge->dev.parent = dev;
        bridge->sysdata = pcie;