Crash on HW back key after deletion of data 76/74776/3
authorKamil Nowac <k.nowac@samsung.com>
Wed, 15 Jun 2016 12:49:43 +0000 (14:49 +0200)
committerKamil Nowac <k.nowac@samsung.com>
Wed, 15 Jun 2016 12:50:08 +0000 (14:50 +0200)
[Issue]    http://suprem.sec.samsung.net/jira/browse/TWF-1494
[Problem]  Passing nullpointer as callback
[Solution] Added nullcheck
[Verify]   Open browser -> Settings -> Delete Web Browsing Data
           -> Delete Selected Data (all checkboxes selected)
           Data should be removed correctly and no crash should
           occur.

Change-Id: I82636fad8b76896dc864f59e493505c85cdfaf7f

services/WebEngineService/WebEngineService.cpp

index db3a52027599213b4b80430ce0b685937c337e1c..b0fc5ff243231ed62c6ec8ad4e896fefd956a235 100644 (file)
@@ -40,6 +40,7 @@ WebEngineService::WebEngineService()
     , m_stopped(false)
     , m_webViewCacheInitialized(false)
     , m_currentTabId(TabId::NONE)
+    , m_currentWebView(nullptr)
     , m_tabIdCreated(-1)
 {
     m_mostRecentTab.clear();
@@ -749,7 +750,8 @@ void WebEngineService::scrollView(const int& dx, const int& dy)
 #if PROFILE_MOBILE
 void WebEngineService::findWord(const char *word, Eina_Bool forward, Evas_Smart_Cb found_cb, void *data)
 {
-    m_currentWebView->findWord(word, forward, found_cb, data);
+    if (m_currentWebView)
+        m_currentWebView->findWord(word, forward, found_cb, data);
 }
 
 bool WebEngineService::getSettingsParam(WebEngineSettings param) {