Remove remnants of the abandoned interface

Change-Id: Ice9c04ca230b6f845c6ae752a7efb176b795a543

diff --git a/srcs/message.cpp b/srcs/message.cpp
index 2c77cc6c4105f4fec0fb065a2814a5f0b2479acc..c76acf85257c362c62548eeb6ff3f08ffdb00b49 100644 (file)
--- a/srcs/message.cpp
+++ b/srcs/message.cpp
@@ -726,11 +726,6 @@ void MakeCredentialResponse::Deserialize(BufferView &input)
     // TODO KEY_MC_RSP_UNSIGNED_EXTENSIONS_OUTPUT
 }
 
-void MakeCredentialResponse::Notify(IMessageObserver &observer)
-{
-    observer.HandleMakeCredentialResponse(*this);
-}
-
 void GetAssertionResponse::Deserialize(BufferView &input)
 {
     CtapResponse::Deserialize(input);
@@ -773,11 +768,6 @@ void GetAssertionResponse::Deserialize(BufferView &input)
      */
 }
 
-void GetAssertionResponse::Notify(IMessageObserver &observer)
-{
-    observer.HandleGetAssertionResponse(*this);
-}
-
 void PostHandshakeResponse::Deserialize(BufferView &input)
 {
     auto helper = CborParsing::Parser::Create(input.data(), input.size());
@@ -909,5 +899,3 @@ void UpdateMessage::Deserialize(BufferView &input)
         THROW_UNKNOWN("Wrong handshake signature length "
                       << m_linkData->m_handshakeSignature.size());
 }
-
-void UpdateMessage::Notify(IMessageObserver &observer) { observer.HandleUpdateMessage(*this); }

diff --git a/srcs/message.h b/srcs/message.h
index e5b1efddec6cb061065559e3b695d69436ce4c29..3e3ac7c7af36b1f471da5942669d2eb3468adeaf 100644 (file)
--- a/srcs/message.h
+++ b/srcs/message.h
@@ -23,8 +23,6 @@
 #include <unordered_map>
 #include <webauthn-types.h>
 
-class IMessageObserver;
-
 enum class MessageType : uint8_t {
     SHUTDOWN = 0, // sent only by  the client
     CTAP = 1,     // CTAP2 command
@@ -145,13 +143,8 @@ private:
     const wauthn_pubkey_cred_request_options_s &m_options;
 };
 
-class IIncomingNotifyingMessage : public IIncomingMessage {
-public:
-    virtual void Notify(IMessageObserver &observer) = 0;
-};
-
 // Contains status code (1B) | CBOR map
-class CtapResponse : public IIncomingNotifyingMessage {
+class CtapResponse : public IIncomingMessage {
 public:
     void Deserialize(BufferView &input) override;
 
@@ -186,7 +179,6 @@ protected:
 class MakeCredentialResponse : public CtapResponse {
 public:
     void Deserialize(BufferView &input) override;
-    void Notify(IMessageObserver &observer) override;
 
     Buffer m_attestationObject;
     std::string m_format;
@@ -197,7 +189,6 @@ public:
 class GetAssertionResponse : public CtapResponse {
 public:
     void Deserialize(BufferView &input) override;
-    void Notify(IMessageObserver &observer) override;
 
     Buffer m_credentialId;
     Buffer m_signature;
@@ -207,10 +198,9 @@ public:
 };
 
 // Contains only CBOR map
-class UpdateMessage : public IIncomingNotifyingMessage {
+class UpdateMessage : public IIncomingMessage {
 public:
     void Deserialize(BufferView &input) override;
-    void Notify(IMessageObserver &observer) override;
 
     struct LinkData {
         Buffer m_contactId;
@@ -227,12 +217,4 @@ private:
     std::optional<LinkData> m_linkData;
 };
 
-class IMessageObserver {
-public:
-    virtual void HandleMakeCredentialResponse(const MakeCredentialResponse &response) = 0;
-    virtual void HandleGetAssertionResponse(const GetAssertionResponse &response) = 0;
-    virtual void HandleUpdateMessage(const UpdateMessage &response) = 0;
-    virtual ~IMessageObserver() = default;
-};
-
 void ValidateDomain(const char *rpId);