projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2d104c3
)
net: netlink: recommend policy range validation
author
Johannes Berg
<johannes.berg@intel.com>
Fri, 27 Jan 2023 07:45:06 +0000
(08:45 +0100)
committer
Jakub Kicinski
<kuba@kernel.org>
Sat, 28 Jan 2023 08:33:51 +0000
(
00:33
-0800)
For large ranges (outside of s16) the documentation currently
recommends open-coding the validation, but it's better to use
the NLA_POLICY_FULL_RANGE() or NLA_POLICY_FULL_RANGE_SIGNED()
policy validation instead; recommend that.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link:
https://lore.kernel.org/r/20230127084506.09f280619d64.I5dece85f06efa8ab0f474ca77df9e26d3553d4ab@changeid
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/netlink.h
patch
|
blob
|
history
diff --git
a/include/net/netlink.h
b/include/net/netlink.h
index
6e1e670
..
b12cd95
100644
(file)
--- a/
include/net/netlink.h
+++ b/
include/net/netlink.h
@@
-276,7
+276,8
@@
enum nla_policy_validation {
* Note that in the interest of code simplicity and
* struct size both limits are s16, so you cannot
* enforce a range that doesn't fall within the range
- * of s16 - do that as usual in the code instead.
+ * of s16 - do that using the NLA_POLICY_FULL_RANGE()
+ * or NLA_POLICY_FULL_RANGE_SIGNED() macros instead.
* Use the NLA_POLICY_MIN(), NLA_POLICY_MAX() and
* NLA_POLICY_RANGE() macros.
* NLA_U8,