Don't call export_symbols.py with duplicate libs
authorDavid Tenty <daltenty@ibm.com>
Wed, 11 Dec 2019 22:21:54 +0000 (17:21 -0500)
committerDavid Tenty <daltenty@ibm.com>
Wed, 11 Dec 2019 22:23:31 +0000 (17:23 -0500)
Summary:
export_symbols.py discards duplicate symbols, assuming they have public definitions, so if we end
up calling it with duplicate libraries we will end up with an inaccurate export list.

Reviewers: jasonliu, stevewan, john.brawn

Reviewed By: john.brawn

Subscribers: mgorny, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70918

llvm/cmake/modules/AddLLVM.cmake

index 518ea60..34f532c 100644 (file)
@@ -873,6 +873,7 @@ function(export_executable_symbols target)
       set(new_libs ${newer_libs})
       set(newer_libs "")
     endwhile()
+    list(REMOVE_DUPLICATES static_libs)
     if (MSVC)
       set(mangling microsoft)
     else()