projects
/
platform
/
upstream
/
gst-plugins-base.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
9948019
)
playsink: Immediately error out if state change fails
author
Sebastian Dröge
<sebastian@centricular.com>
Sat, 17 Oct 2015 19:20:31 +0000
(22:20 +0300)
committer
Sebastian Dröge
<sebastian@centricular.com>
Tue, 20 Oct 2015 07:15:50 +0000
(10:15 +0300)
Otherwise we chain up to the parent class' change_state function and might
override the failure with SUCCESS.
https://bugzilla.gnome.org/show_bug.cgi?id=756611
gst/playback/gstplaysink.c
patch
|
blob
|
history
diff --git
a/gst/playback/gstplaysink.c
b/gst/playback/gstplaysink.c
index 6250134e94411ee9fd1226414f98640e2481c08c..6c5a2cfeb17d5f391bb66678f8c1a192d15be3a8 100644
(file)
--- a/
gst/playback/gstplaysink.c
+++ b/
gst/playback/gstplaysink.c
@@
-4769,8
+4769,10
@@
gst_play_sink_change_state (GstElement * element, GstStateChange transition)
ret = GST_STATE_CHANGE_ASYNC;
/* block all pads here */
- if (!gst_play_sink_reconfigure (playsink))
+ if (!gst_play_sink_reconfigure (playsink))
{
ret = GST_STATE_CHANGE_FAILURE;
+ goto activate_failed;
+ }
break;
case GST_STATE_CHANGE_PAUSED_TO_READY:
/* unblock all pads here */