crypto: sun4i-ss - initialize need_fallback
authorCorentin Labbe <clabbe@baylibre.com>
Mon, 14 Dec 2020 20:02:29 +0000 (20:02 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Mar 2021 10:38:32 +0000 (11:38 +0100)
commit 4ec8977b921fd9d512701e009ce8082cb94b5c1c upstream.

The need_fallback is never initialized and seem to be always true at runtime.
So all hardware operations are always bypassed.

Fixes: 0ae1f46c55f87 ("crypto: sun4i-ss - fallback when length is not multiple of blocksize")
Cc: <stable@vger.kernel.org>
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c

index d646d2d..ffa628c 100644 (file)
@@ -194,7 +194,7 @@ static int sun4i_ss_cipher_poll(struct skcipher_request *areq)
        unsigned int obo = 0;   /* offset in bufo*/
        unsigned int obl = 0;   /* length of data in bufo */
        unsigned long flags;
-       bool need_fallback;
+       bool need_fallback = false;
 
        if (!areq->cryptlen)
                return 0;