udf: Truncate added extents on failed expansion
authorJan Kara <jack@suse.cz>
Thu, 15 Dec 2022 13:24:03 +0000 (14:24 +0100)
committerJan Kara <jack@suse.cz>
Mon, 9 Jan 2023 09:39:52 +0000 (10:39 +0100)
When a file expansion failed because we didn't have enough space for
indirect extents make sure we truncate extents created so far so that we
don't leave extents beyond EOF.

CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
fs/udf/inode.c

index 9655fc0..e077183 100644 (file)
@@ -431,8 +431,10 @@ static int udf_do_extend_file(struct inode *inode,
        }
 
        if (fake) {
-               udf_add_aext(inode, last_pos, &last_ext->extLocation,
-                            last_ext->extLength, 1);
+               err = udf_add_aext(inode, last_pos, &last_ext->extLocation,
+                                  last_ext->extLength, 1);
+               if (err < 0)
+                       goto out_err;
                count++;
        } else {
                struct kernel_lb_addr tmploc;
@@ -466,7 +468,7 @@ static int udf_do_extend_file(struct inode *inode,
                err = udf_add_aext(inode, last_pos, &last_ext->extLocation,
                                   last_ext->extLength, 1);
                if (err)
-                       return err;
+                       goto out_err;
                count++;
        }
        if (new_block_bytes) {
@@ -475,7 +477,7 @@ static int udf_do_extend_file(struct inode *inode,
                err = udf_add_aext(inode, last_pos, &last_ext->extLocation,
                                   last_ext->extLength, 1);
                if (err)
-                       return err;
+                       goto out_err;
                count++;
        }
 
@@ -489,6 +491,11 @@ out:
                return -EIO;
 
        return count;
+out_err:
+       /* Remove extents we've created so far */
+       udf_clear_extent_cache(inode);
+       udf_truncate_extents(inode);
+       return err;
 }
 
 /* Extend the final block of the file to final_block_len bytes */