staging: ks7010: use strscpy() to instead of strncpy()
authorXu Panda <xu.panda@zte.com.cn>
Mon, 26 Dec 2022 11:03:24 +0000 (19:03 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Jan 2023 18:24:57 +0000 (19:24 +0100)
The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL-terminated strings.

Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Signed-off-by: Yang Yang <yang.yang29@zte.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/202212261903245548969@zte.com.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ks7010/ks_wlan_net.c

index 044c807..e03c87f 100644 (file)
@@ -382,8 +382,7 @@ static int ks_wlan_get_nick(struct net_device *dev,
                return -EPERM;
 
        /* for SLEEP MODE */
-       strncpy(extra, priv->nick, 16);
-       extra[16] = '\0';
+       strscpy(extra, priv->nick, 17);
        dwrq->data.length = strlen(extra) + 1;
 
        return 0;