Apply multi-hal interface 29/314329/1 accepted/tizen_unified_dev accepted/tizen/9.0/unified/20241030.234450 accepted/tizen/unified/20240712.160053 accepted/tizen/unified/dev/20240715.080559 accepted/tizen/unified/x/asan/20241224.003809 tizen_9.0_m2_release
authorWootak Jung <wootak.jung@samsung.com>
Wed, 10 Jul 2024 06:57:04 +0000 (15:57 +0900)
committerWootak Jung <wootak.jung@samsung.com>
Wed, 10 Jul 2024 06:57:04 +0000 (15:57 +0900)
Change-Id: I0f8ab7f5c56c919c459aaa046393255f62c88f45

CMakeLists.txt
packaging/hal-backend-bluetooth-vim3.spec
src/CMakeLists.txt
src/hal-backend-bluetooth.c
src/log.h [new file with mode: 0644]

index 1099fb4bdb5bfe7a74d7db9ae5b376bec2f0c346..1de2d079a89563145d9fed5655a094244d07ce1a 100644 (file)
@@ -1,6 +1,10 @@
 CMAKE_MINIMUM_REQUIRED(VERSION 2.6)
 PROJECT(hal-backend-bluetooth-vim3 C)
 
+IF(ENABLE_DLOG STREQUAL on)
+       ADD_DEFINITIONS("-DFEATURE_DLOG")
+ENDIF()
+
 FOREACH(flag ${package_CFLAGS})
        SET(EXTRA_CFLAGS "${EXTRA_CFLAGS} ${flag}")
 ENDFOREACH(flag)
index 1958122a420a678b16138b5c62e13b6ce6f8329d..bbd96a1388f26ab485182ee73853fd5a2fd82db5 100644 (file)
@@ -7,9 +7,7 @@ License:    Apache-2.0
 Source0:    hal-backend-bluetooth-vim3-%{version}.tar.gz
 
 BuildRequires:  cmake
-BuildRequires:  pkgconfig(dlog)
-BuildRequires:  pkgconfig(hal-api-common)
-BuildRequires:  pkgconfig(hal-api-bluetooth)
+BuildRequires:  pkgconfig(hal-rootstrap)
 
 %description
 VIM3 firmware and tools for bluetooth
index 964fe5203298ab96ec845bff4d5a2a3fd09f40b6..a5d2986f4be6aa80e700d9bab0d59de7ba5a9962 100644 (file)
@@ -5,9 +5,7 @@ INCLUDE_DIRECTORIES(${PROJECT_SOURCE_DIR}/include)
 
 INCLUDE(FindPkgConfig)
 pkg_check_modules(hal-backend-bluetooth_pkgs REQUIRED
-       dlog
-       hal-api-common
-       hal-api-bluetooth
+       hal-rootstrap
 )
 
 SET(SRCS
index 5f9846dce77d707ad5b8bc3882c76857d63990f7..a3f5078dd8e745e1a676d96f15ffcdaa76375faa 100644 (file)
@@ -1,13 +1,27 @@
+/*
+ * Copyright (c) 2024 Samsung Electronics Co., Ltd All Rights Reserved
+ *
+ * Licensed under the Apache License, Version 2.0 (the License);
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <stdint.h>
 #include <errno.h>
-#include <dlog.h>
 
 #include <hal/hal-bluetooth-interface.h>
 
-#undef LOG_TAG
-#define LOG_TAG "HALAPI_BLUETOOTH"
+#include "log.h"
 
 #define EXPORT __attribute__ ((visibility("default")))
 
@@ -16,13 +30,13 @@ static int bluetooth_vim3_start(void)
        int ret;
        ret = system("/hal/etc/bluetooth/bt-dev-start.sh");
        if (ret == 0x100) {
-               LOGE("script internal failed");
+               _E("script internal failed");
                return HAL_BACKEND_ERROR_INTERNAL;
        } else if (ret == 0x200) {
-               LOGE("script timeout failed");
+               _E("script timeout failed");
                return HAL_BACKEND_ERROR_TIMEOUT;
        }
-       LOGD("script started successfully");
+       _D("script started successfully");
        return HAL_BACKEND_ERROR_NONE;
 }
 
@@ -31,13 +45,13 @@ static int bluetooth_vim3_stop(void)
        int ret;
        ret = system("/hal/etc/bluetooth/bt-dev-end.sh");
        if (ret == 0x100) {
-               LOGE("script internal failed");
+               _E("script internal failed");
                return HAL_BACKEND_ERROR_INTERNAL;
        } else if (ret == 0x200) {
-               LOGE("script timeout failed");
+               _E("script timeout failed");
                return HAL_BACKEND_ERROR_TIMEOUT;
        }
-       LOGD("script started successfully");
+       _D("script started successfully");
        return HAL_BACKEND_ERROR_NONE;
 }
 
@@ -45,31 +59,32 @@ static int bluetooth_vim3_init(void **data)
 {
        hal_backend_bluetooth_funcs *bluetooth_funcs;
 
-       bluetooth_funcs = calloc(1, sizeof(hal_backend_bluetooth_funcs));
+       if (!data) {
+               _E("data is NULL");
+               return -EINVAL;
+    }
+
+       bluetooth_funcs = *(hal_backend_bluetooth_funcs **)data;
        if (!bluetooth_funcs)
-               return -ENOMEM;
+               return -EINVAL;
 
        bluetooth_funcs->start = bluetooth_vim3_start;
        bluetooth_funcs->stop = bluetooth_vim3_stop;
 
-       *data = (void *)bluetooth_funcs;
-
        return 0;
 }
 
 static int bluetooth_vim3_exit(void *data)
 {
-       if (!data)
-               return -EINVAL;
-       free(data);
-
        return 0;
 }
 
 hal_backend EXPORT hal_backend_bluetooth_data = {
        .name = "bluetooth-vim3",
-       .vendor = "VIM3",
+       .vendor = "Samsung",
        .abi_version = HAL_ABI_VERSION_TIZEN_6_5,
        .init = bluetooth_vim3_init,
        .exit = bluetooth_vim3_exit,
+       .major_version = 1,
+       .minor_version = 0,
 };
diff --git a/src/log.h b/src/log.h
new file mode 100644 (file)
index 0000000..819bec2
--- /dev/null
+++ b/src/log.h
@@ -0,0 +1,29 @@
+/*
+ * Copyright (c) 2024 Samsung Electronics Co., Ltd All Rights Reserved
+ *
+ * Licensed under the Apache License, Version 2.0 (the License);
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#ifdef FEATURE_DLOG
+       #define LOG_TAG "HAL_BACKEND_BLUETOOTH_VIM3"
+       #include <dlog.h>
+       #define _D(fmt, args...)        dlog_print(DLOG_DEBUG, LOG_TAG, fmt, ##args)
+       #define _I(fmt, args...)        dlog_print(DLOG_INFO, LOG_TAG, fmt, ##args)
+       #define _W(fmt, args...)        dlog_print(DLOG_WARN, LOG_TAG, fmt, ##args)
+       #define _E(fmt, args...)        dlog_print(DLOG_ERROR, LOG_TAG, fmt, ##args)
+#else
+       #define _D(x, ...)
+       #define _I(x, ...)
+       #define _W(x, ...)
+       #define _E(x, ...)
+#endif