alawdec, mulawdec: demote some debug messages from ERROR to WARNING or DEBUG

Non-ok flow returns may happen for a variety of perfectly legitimate and expected reasons
(temporarily not linked, seeking, pipeline shutdown), so we really shouldn't spew ERROR
debug messages to stderr in those cases. Fixes #570781. (Seems like someone already took
care of some of these.)

diff --git a/gst/law/alaw-decode.c b/gst/law/alaw-decode.c
index f308cf7..ac4c6df 100644 (file)
--- a/gst/law/alaw-decode.c
+++ b/gst/law/alaw-decode.c
@@ -293,14 +293,13 @@ gst_alaw_dec_chain (GstPad * pad, GstBuffer * buffer)
 not_negotiated:
   {
     gst_buffer_unref (buffer);
-    GST_ERROR_OBJECT (alawdec, "no format negotiated");
-    ret = GST_FLOW_NOT_NEGOTIATED;
-    return ret;
+    GST_WARNING_OBJECT (alawdec, "no input format set: not-negotiated");
+    return GST_FLOW_NOT_NEGOTIATED;
   }
 alloc_failed:
   {
     gst_buffer_unref (buffer);
-    GST_DEBUG_OBJECT (alawdec, "pad alloc failed %d (%s)", ret,
+    GST_DEBUG_OBJECT (alawdec, "pad alloc failed, flow: %s",
         gst_flow_get_name (ret));
     return ret;
   }

diff --git a/gst/law/mulaw-decode.c b/gst/law/mulaw-decode.c
index 83b3839..831ef0f 100644 (file)
--- a/gst/law/mulaw-decode.c
+++ b/gst/law/mulaw-decode.c
@@ -258,13 +258,13 @@ gst_mulawdec_chain (GstPad * pad, GstBuffer * buffer)
   /* ERRORS */
 not_negotiated:
   {
-    GST_ERROR_OBJECT (mulawdec, "no format negotiated");
+    GST_WARNING_OBJECT (mulawdec, "no input format set: not-negotiated");
     gst_buffer_unref (buffer);
     return GST_FLOW_NOT_NEGOTIATED;
   }
 alloc_failed:
   {
-    GST_DEBUG_OBJECT (mulawdec, "pad alloc failed %d (%s)", ret,
+    GST_DEBUG_OBJECT (mulawdec, "pad alloc failed, flow: %s",
         gst_flow_get_name (ret));
     gst_buffer_unref (buffer);
     return ret;